add support for proxy servers #13
Closed
+138
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
any ideas on when this will be available in an official build? |
|
We're getting v2 (see the branch if you're interested) merged to master soon, then we'll swing back to this. |
smurthas
added a commit
to smurthas/KeenClient-Java
that referenced
this pull request
Oct 9, 2014
Lots of ideas and code from keenlabs#13, thanks for the starting point!
smurthas
added a commit
to smurthas/KeenClient-Java
that referenced
this pull request
Oct 9, 2014
Lots of ideas and code from keenlabs#13, thanks for the starting point!
Merged
|
I'm going to close this. It's been stale for a long time. I will open a new issue with the goal of achieving this same thing, but I think the code is so old it'll be more work than starting from scratch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves issue #12 and adds support for HTTP proxy servers in the Keen IO client.
A couple of notes:
1) It does not support authenticated proxies. users can set the authenticator on their own
2) It currently only supports HTTP proxies (this is the vast majority of users)
3) Not setting the proxy does not block configuring a container level one.
A note on code:
I picked constructor injection to get the proxy into KeenHttpRequestRunnable. This was a personal preference. If you would rather I directly reference the static config at the point where it is used I can change it.